Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hive integration #1093

Merged
merged 1 commit into from
Apr 3, 2022
Merged

fix: Hive integration #1093

merged 1 commit into from
Apr 3, 2022

Conversation

budde377
Copy link
Collaborator

@budde377 budde377 commented Apr 3, 2022

This PR fixes #1091. The underlying issue is that Hive doesn't work well with generics. By not assuming that the box will be Box<Map<String, dynamic>?>, but rather Box<Map<dynamic, dynamic>?> and handling conversion appropriately, we can prevent the bugs reported.

@codecov
Copy link

codecov bot commented Apr 3, 2022

Codecov Report

Merging #1093 (a8726cb) into main (ebc96e7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1093   +/-   ##
=======================================
  Coverage   60.01%   60.01%           
=======================================
  Files          41       41           
  Lines        1528     1528           
=======================================
  Hits          917      917           
  Misses        611      611           
Impacted Files Coverage Δ
packages/graphql/lib/src/cache/hive_store.dart 94.73% <100.00%> (ø)
packages/graphql/lib/src/cache/store.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc96e7...a8726cb. Read the comment docs.

@budde377 budde377 requested a review from vincenzopalazzo April 3, 2022 16:42
@budde377 budde377 force-pushed the fix-hive branch 2 times, most recently from dd152d5 to 62b5ed6 Compare April 3, 2022 17:00
vincenzopalazzo
vincenzopalazzo previously approved these changes Apr 3, 2022
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor in the commit message

the change required only the client changelog to be updated, so we need to use fix(graphql): ..

@vincenzopalazzo vincenzopalazzo merged commit e7b9ce9 into main Apr 3, 2022
@budde377 budde377 deleted the fix-hive branch June 27, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_InternalLinkedHashMap<dynamic, dynamic> is not a subtype of Map<String, dynamic>? in type cast
2 participants