Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double call in onAfterChangeSlider method #161

Closed
GenisDiaz opened this issue Feb 1, 2020 · 3 comments · Fixed by #163
Closed

Double call in onAfterChangeSlider method #161

GenisDiaz opened this issue Feb 1, 2020 · 3 comments · Fixed by #163
Labels
bug

Comments

@GenisDiaz
Copy link

GenisDiaz commented Feb 1, 2020 •
edited
Loading

Hi!

I use the onAfterChangeSlider method to do a request with the new range values and this method is called twice every time I move a thumb.

Is this the regular behavior, or I'm doing something wrong?

thanks in advance!
@TreTuna
Copy link

TreTuna commented Feb 11, 2020

I was just coming on here to report this. We use the onAfterChange method for analytics tracking and are now getting double reporting. I'm having to revert back our install to v0.11.2 for now until I can figure out what's going on here. What I've figured out so far is that it's getting called once after the change and then again after the slider loses focus.

@stonebk
Copy link
Contributor

stonebk commented Feb 13, 2020

Looks like onBeforeChange is also called twice 🤔

@stonebk stonebk added the bug label Feb 13, 2020
stonebk pushed a commit that referenced this issue Feb 13, 2020
fix: change event handlers are now more reliable
548a8fc 
`onBeforeChange` and `onAfterChange` should only be called once per action,
and none of the change events should fire if the action does not result in a change in value.

Fixes #161
@stonebk stonebk mentioned this issue Feb 13, 2020
Merged
stonebk pushed a commit that referenced this issue Feb 14, 2020
@stonebk
fix: change event handlers are now more reliable
f1282d4 
`onBeforeChange` and `onAfterChange` should only be called once per action,
and none of the change events should fire if the action does not result in a change in value.

Fixes #161
@stonebk
Copy link
Contributor

stonebk commented Feb 14, 2020

[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: change event handlers are now more reliable zillow/react-slider
3 participants
@stonebk @GenisDiaz @TreTuna