AIP-653: Sym-link python SDK components to avoid poetry lacking subdirectory install capabilities #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectory install capabilities
talebzeghmi
approved these changes
Nov 3, 2020
alexlatchford
pushed a commit
that referenced
this pull request
Aug 30, 2021
* Changes: * add kfp v2 hello world sample * generate go proto code * code to unmarshal via jsonpb * generate container spec * add root DAG task and Makefile to run in argo * env setup to quickly build driver container * generate mlmd grpc golang client * mlmd grpc client usage example * driver-dag: put execution and context * driver dag: put context only when execution is a DAG * driver task: resolve parameter from parent execution * chain dag driver with task driver * driver: output argo parameters * driver: build driver docker image * driver: push image to dev registry * compiler: root dag driver compiler * mlmd doc * driver: use task spec and executor spec as driver input instead * driver: pod spec patch output for type EXECUTOR * compiler: passing - parameter placeholder with hello world example * include generated argo workflow in source control * driver no longer outputs parameters * publisher: publish parameters to execution custom properties * driver, publisher: execution state * publisher: remove built binary from repo * sample: add producer consumer sample * sample: producer consumer sample with only parameters * e2e output parameter support * e2e: driver resolves input parameter from tasks in the same DAG * compiler: convert KFP task dependency to argo task dependency * feat: refactor publisher so it can run as an entrypoint * build: entrypoint image * feat: executor and publisher in one container via entrypoint rewriting * fixed compile error (#1) * add licenses * update readme Co-authored-by: capri-xiyue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to install the ZG fork of
kfpwithpoetry.Unfortunately
poetryhas a limitation where it cannot installsubdirectorypackages forgitpaths, see python-poetry/poetry#755. So to get around this issue we symlink the appropriate Python SDK files to the root directory instead 😅As an interesting aside another approach considered for this was to publish a package to Github Packages and have the
aip-kfp-sdklibrary rely on it but as per github/roadmap#94 python packages are not support 😒 For the future open-source workstream it is likely we'll want to publish packages to the global PyPI.