Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #336

Merged
merged 1 commit into from
May 15, 2024
Merged

Update Dockerfile #336

merged 1 commit into from
May 15, 2024

Conversation

erigo
Copy link
Contributor

@erigo erigo commented May 10, 2024

Add MinIO Client for migrating data in each Milvus cluster.

Add MinIO Client for migrating data in each Milvus cluster.
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: erigo

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

mergify bot commented May 10, 2024

@erigo Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco label May 10, 2024
Copy link

mergify bot commented May 10, 2024

@erigo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@wayblink
Copy link
Contributor

@erigo Hi, Thanks for contribution. Why we need that?

@wayblink
Copy link
Contributor

@erigo I get your point, good for now. We will support cross storage backup in our roadmap. Then you will not need to use mc client to copy to local. How about the image size change after you add mc client.

@erigo
Copy link
Contributor Author

erigo commented May 10, 2024

image size from 41.7MB to 68.2MB.

@wayblink wayblink merged commit f8685c7 into zilliztech:main May 15, 2024
18 of 22 checks passed
@wayblink
Copy link
Contributor

@erigo Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants