Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conan: make glog shared #972

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

sparknack
Copy link
Contributor

This change is aimed to fix knowhere_tests running error after latest modification.

Copy link

mergify bot commented Dec 3, 2024

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@sparknack
Copy link
Contributor Author

issue: #971

@sparknack
Copy link
Contributor Author

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug This PR is a bug fix label Dec 3, 2024
@mergify mergify bot added the ci-passed label Dec 3, 2024
@Presburger
Copy link
Collaborator

/lgtm

@zhengbuqian
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sparknack, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy
Copy link
Collaborator

foxspy commented Dec 3, 2024

/kind improvement

Copy link

mergify bot commented Dec 3, 2024

@sparknack Please remove redundant kind/xxx labels and make sure that there is only one kind/xxx label of your Pull Request. (eg. “/remove-kind improvement”)

Copy link

mergify bot commented Dec 3, 2024

@sparknack 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@foxspy
Copy link
Collaborator

foxspy commented Dec 3, 2024

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 4e3a54d into zilliztech:main Dec 3, 2024
8 of 9 checks passed
lowener pushed a commit to lowener/knowhere that referenced this pull request Jan 30, 2025
cqy123456 pushed a commit to cqy123456/zilliztech-knowhere that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants