Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ivf_iterator will copy query vectors #901

Merged

Conversation

alwayslove2013
Copy link
Collaborator

issue: #900

Copy link

mergify bot commented Oct 18, 2024

@alwayslove2013 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@PwzXxm
Copy link
Collaborator

PwzXxm commented Oct 18, 2024

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug This PR is a bug fix label Oct 18, 2024
@PwzXxm
Copy link
Collaborator

PwzXxm commented Oct 18, 2024

/lgtm
/approve

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alwayslove2013, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 18, 2024
@sre-ci-robot sre-ci-robot merged commit 7788994 into zilliztech:main Oct 18, 2024
10 of 11 checks passed
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (3c46f4c) to head (747d780).
Report is 224 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #901       +/-   ##
=========================================
+ Coverage      0   79.56%   +79.56%     
=========================================
  Files         0       81       +81     
  Lines         0     6270     +6270     
=========================================
+ Hits          0     4989     +4989     
- Misses        0     1281     +1281     

see 81 files with indirect coverage changes

cqy123456 pushed a commit to cqy123456/zilliztech-knowhere that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants