Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create index check for ScaNN and fix UTs #816

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

chasingegg
Copy link
Collaborator

@chasingegg chasingegg commented Sep 5, 2024

Currently we have cpu check for ScaNN when building index/searching, we could also check while creating index and stop early for those old cpu models.
Also, check cpu model in UTs.

/kind improvement

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.15%. Comparing base (3c46f4c) to head (73e5540).
Report is 173 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #816       +/-   ##
=========================================
+ Coverage      0   72.15%   +72.15%     
=========================================
  Files         0       84       +84     
  Lines         0     6126     +6126     
=========================================
+ Hits          0     4420     +4420     
- Misses        0     1706     +1706     

see 84 files with indirect coverage changes

@cqy123456
Copy link
Collaborator

/lgtm

@mergify mergify bot added the ci-passed label Sep 5, 2024
@sre-ci-robot sre-ci-robot merged commit d61e108 into zilliztech:main Sep 5, 2024
13 checks passed
@chasingegg chasingegg deleted the scann-ut branch September 5, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants