[Enhancement] add statically hasRawData interface #751
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
@foxspy 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
foxspy
force-pushed
the
add_has_raw_data_static_interface
branch
2 times, most recently
from
b547ff2 to
eec893b
Compare
|
issue: #750 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
=========================================
+ Coverage 0 72.48% +72.48%
=========================================
Files 0 70 +70
Lines 0 5215 +5215
=========================================
+ Hits 0 3780 +3780
- Misses 0 1435 +1435 |
Signed-off-by: xianliang.li <[email protected]>
foxspy
force-pushed
the
add_has_raw_data_static_interface
branch
from
eec893b to
9ef7d21
Compare
| @@ -38,6 +42,93 @@ SuppportMmapIndexTypeCheck(const std::string& index_name) { | |||
| return false; | |||
| } | |||
| } | |||
|
|
|||
| inline bool | |||
| CheckBooleanInJson(const knowhere::Json& json, std::string key, bool target) { | |||
There was a problem hiding this comment.
any checks for 1 or 0 as well?
Something like value == "1" or value == 1
There was a problem hiding this comment.
This is consistent with the constraint represented by the bool in the configuration. Currently, something like 1 would be considered an invalid parameter.
|
lgtm overall, just a couple of questions |
|
/lgtm |
|
/unhold |
|
/kind improvement |
issue: #750