Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use std::vector::reserve to correctly initialize vals #721

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #720
/kind bug

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (3c46f4c) to head (3e68dfb).
Report is 126 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #721       +/-   ##
=========================================
+ Coverage      0   72.31%   +72.31%     
=========================================
  Files         0       69       +69     
  Lines         0     4869     +4869     
=========================================
+ Hits          0     3521     +3521     
- Misses        0     1348     +1348     

see 69 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 22, 2024
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [liliu-z,zhengbuqian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 138fe96 into zilliztech:main Jul 22, 2024
13 checks passed
@zhengbuqian zhengbuqian deleted the fix-sparse-drop branch July 22, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants