Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty sparse row #704

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

zhengbuqian
Copy link
Collaborator

by not adding zeros to the inverted index, while still adding to the raw data.

added unit tests for searching/retrieving.

issue: #687
/kind improvement

Signed-off-by: Buqian Zheng <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.30%. Comparing base (3c46f4c) to head (1f8c67e).
Report is 119 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #704       +/-   ##
=========================================
+ Coverage      0   72.30%   +72.30%     
=========================================
  Files         0       69       +69     
  Lines         0     4868     +4868     
=========================================
+ Hits          0     3520     +3520     
- Misses        0     1348     +1348     

see 69 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 15, 2024
@alexanderguzhva
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot merged commit 02c2c0f into zilliztech:main Jul 15, 2024
13 checks passed
@zhengbuqian zhengbuqian deleted the allow-empty-sparse-row branch July 16, 2024 02:13
xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants