Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip ci] Update cardinal version #684

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

foxspy
Copy link
Collaborator

@foxspy foxspy commented Jul 3, 2024

No description provided.

Signed-off-by: xianliang.li <[email protected]>
Copy link

mergify bot commented Jul 3, 2024

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@mergify mergify bot added the ci-passed label Jul 3, 2024
@foxspy
Copy link
Collaborator Author

foxspy commented Jul 4, 2024

/kind enhancement

Copy link
Collaborator

@chasingegg chasingegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chasingegg
Copy link
Collaborator

/kind improvement

Copy link

mergify bot commented Jul 4, 2024

@foxspy Please remove redundant kind/xxx labels and make sure that there is only one kind/xxx label of your Pull Request. (eg. “/remove-kind improvement”)

@sre-ci-robot sre-ci-robot merged commit 8abbe52 into zilliztech:main Jul 4, 2024
8 checks passed
xxxlzhxxx pushed a commit to xxxlzhxxx/knowhere that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants