a theoretical fix for binary data type

[alexanderguzhva]

Faiss IndexBinary-derived indices prohibit dim % 8 != 0 use cases. Still, it is needed to correctly handle non-standard dim values inside Knowhere, just in hope that a Faiss might lift its restriction one day.

/kind improvement

[mergify]

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

1. If you're fixing a bug, label it as kind/bug.
2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (3c46f4c) to head (366d231).
Report is 108 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##           main     #676       +/-   ##
=========================================
+ Coverage      0   71.75%   +71.75%     
=========================================
  Files         0       69       +69     
  Lines         0     4737     +4737     
=========================================
+ Hits          0     3399     +3399     
- Misses        0     1338     +1338     

see 69 files with indirect coverage changes

[xiaofan-luan]

do we really need to?

[xiaofan-luan]

I thought it make much more sense to align with byte.

[chasingegg]

Currently milvus has constraints for dim % 8 == 0 on binary vectors, but this change shall not cause any problems

[xiaofan-luan]

Currently milvus has constraints for dim % 8 == 0 on binary vectors, but this change shall not cause any problems

yes. i'm just wondering what will be use case for that.

[alexanderguzhva]

the use case is the aesthetics of a code that handles the situation correctly, even if the situation is improbable :)

[chasingegg]

Agree, we could be ready for possible future change(dim % 8 != 0) even if it is unlikely:) , at least the code is correct and more robust

the use case is the aesthetics of a code that handles the situation correctly, even if the situation is improbable :)

[chasingegg]

/lgtm

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva, chasingegg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chasingegg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chasingegg]

/kind improvement