Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove two unused variables #495

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

zhjwpku
Copy link
Contributor

@zhjwpku zhjwpku commented Apr 10, 2024

and polish two comments which are not precise.

and polish two comments which are not precise.

Signed-off-by: Zhao Junwang <[email protected]>
@sre-ci-robot
Copy link
Collaborator

Welcome @zhjwpku! It looks like this is your first PR to zilliztech/knowhere 🎉

Copy link

mergify bot commented Apr 10, 2024

@zhjwpku 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@mergify mergify bot added the ci-passed label Apr 10, 2024
@zhjwpku
Copy link
Contributor Author

zhjwpku commented Apr 10, 2024

/assign @cqy123456

@cqy123456
Copy link
Collaborator

/lgtm

Copy link
Collaborator

@chasingegg chasingegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for the contribution!

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, zhjwpku

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chasingegg
Copy link
Collaborator

/kind improvement

@sre-ci-robot sre-ci-robot merged commit 07c3887 into zilliztech:main Apr 10, 2024
8 of 9 checks passed
@zhjwpku zhjwpku deleted the remove_unused_variable branch May 13, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants