Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix knowhere build #1027

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix knowhere build #1027

merged 1 commit into from
Jan 14, 2025

Conversation

chasingegg
Copy link
Collaborator

/kind improvement

Signed-off-by: chasingegg <[email protected]>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cqy123456
Copy link
Collaborator

/lgtm

@mergify mergify bot added the ci-passed label Jan 14, 2025
@sre-ci-robot sre-ci-robot merged commit 45d757c into zilliztech:main Jan 14, 2025
10 of 11 checks passed
@chasingegg chasingegg deleted the fix-build branch January 14, 2025 11:45
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.81%. Comparing base (3c46f4c) to head (ae45a5a).
Report is 291 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #1027       +/-   ##
=========================================
+ Coverage      0   73.81%   +73.81%     
=========================================
  Files         0       82       +82     
  Lines         0     7488     +7488     
=========================================
+ Hits          0     5527     +5527     
- Misses        0     1961     +1961     

see 82 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants