Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

todo: merge AVX-512 version of PQFastScan #511

Closed
alexanderguzhva opened this issue Apr 18, 2024 · 6 comments
Closed

todo: merge AVX-512 version of PQFastScan #511

alexanderguzhva opened this issue Apr 18, 2024 · 6 comments
Labels

Comments

@alexanderguzhva
Copy link
Collaborator

alexanderguzhva commented Apr 18, 2024

Faiss PR facebookresearch/faiss#3276

AVX-512 implementation for PQFastScan for QBS.
For local benchmarks on 4th gen Xeon, the QPS is up to 10% higher, mostly for a single query case. But as far as I remember, production cases would show higher performance improvements.

It cannot be cherry-picked or copy-pasted, because Faiss baseline uses #ifdef mechanism for deciding whether to use AVX-512, and Knowhere uses dynamic hooks. Some additional code is needed.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label May 19, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2024
@alexanderguzhva
Copy link
Collaborator Author

/reopen

@sre-ci-robot sre-ci-robot reopened this May 26, 2024
@sre-ci-robot
Copy link
Collaborator

@alexanderguzhva: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the stale label May 27, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label Jun 26, 2024
@alexanderguzhva
Copy link
Collaborator Author

/reopen

@github-actions github-actions bot removed the stale label Jun 27, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@github-actions github-actions bot added the stale label Jul 27, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants