Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide about StreamReader #3330

Closed
craigh opened this issue Dec 27, 2016 · 1 comment
Closed

Decide about StreamReader #3330

craigh opened this issue Dec 27, 2016 · 1 comment
Milestone
1.4.6

Comments

@craigh
Copy link
Member

craigh commented Dec 27, 2016

at /src/lib/StreamReader there is a Pear-style named class.

decide to keep or remove. if keep, probably need to refactor and alias for BC

seems related to concepts here:
http://php.net/manual/en/ref.stream.php
http://php-and-symfony.matthiasnoback.nl/2012/04/php-setting-up-a-stream-wrapper-for-manipulating-the-dom/
http://php-and-symfony.matthiasnoback.nl/2012/04/php-a-custom-stream-wrapper-part-2-reading-and-seeking/
@craigh craigh added this to the 1.4.5 milestone Dec 27, 2016
@Guite
Copy link
Member

Guite commented Dec 27, 2016

Seems to be used by the old Gettext stuff.
Personally I'd be glad to get rid of it.

@Guite Guite modified the milestones: 1.4.5, 1.4.6, 1.4.7 Dec 28, 2016
@craigh craigh mentioned this issue Jan 1, 2017
Merged
craigh added a commit that referenced this issue Jan 2, 2017
@craigh
remove some deprecated files/classes closes #3330
801e4fa
@craigh craigh closed this as completed Jan 2, 2017
@craigh craigh modified the milestones: 1.4.6, 1.4.7 Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.6
Development

No branches or pull requests
2 participants
@Guite @craigh