Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/remove unneeded JS vendors #2416

Closed
craigh opened this issue Apr 12, 2015 · 6 comments
Closed

update/remove unneeded JS vendors #2416

craigh opened this issue Apr 12, 2015 · 6 comments
Labels
Milestone

Comments

@craigh
Copy link
Member

craigh commented Apr 12, 2015

Several vendors are included in our own repo.

Many of these, in combination with those included at by composer, are either redundant, woefully out of date, or irrelevant.

These libraries should be updated or removed as appropriate. Some others should be justified for the continued inclusion in the core.

possible redundancies:
Color

  1. PickyColor
  2. jquery-minicolors

shim/shiv/polyfill

  1. Webshim
  2. Modernizer
  3. html5shiv

tree

  1. jstree
  2. Zikula.Menutree.Tree.js

calendars

  1. DHTML calendar
  2. jQuery calendar

There are others probably . I realize SOME of these are present due to BC concerns and this is understandable.

For 2.0.0 we should significantly reduce this...

@shefik @cmfcmf @Guite

@craigh craigh added the UI/UX label Apr 12, 2015
@craigh craigh added this to the 2.0.0 milestone Apr 12, 2015
@shefik
Copy link
Contributor

shefik commented Apr 12, 2015

I don't think we need html5shiv anymore, since we have dropped support for older versions of IE.

"The HTML5 Shiv enables use of HTML5 sectioning elements in legacy Internet Explorer and provides basic HTML5 styling for Internet Explorer 6-9, Safari 4.x (and iPhone 3.x), and Firefox 3.x."

https://github.com/aFarkas/html5shiv

@shefik
Copy link
Contributor

shefik commented Apr 12, 2015

We currently use Modernizr 2.6.2, but the latest version is Modernizr 2.8.3, so it should be upgraded. It is still useful for detecting browser features and applying custom CSS classes, based on the detected features. Modernizr is not a polyfill, so it doesn't add features to a browser. It only detects what is available. Webshim is polyfill that adds features. So, the two can work in conjunction with each other.

@shefik
Copy link
Contributor

shefik commented Apr 12, 2015

Both PickyColor and jquery-minicolors can probably be removed, because we should use the HTML5 native "color" input type. For browsers that don't currently support the "color" input type, Webshim can load its polyfill.

Demo:

http://afarkas.github.io/webshim/demos/demos/cfgs/input-color.html

@Guite
Copy link
Member

Guite commented Apr 13, 2015

PickyColor is for BC only.
jquery-minicolors could indeed be removed (was added in #1728).

As this issue is scheduled for 2.0.0 probably both scripts can be removed then without problems.

@Guite
Copy link
Member

Guite commented Apr 13, 2015

Depends on #2034

@craigh craigh changed the title update/remove needed JS vendors update/remove unneeded JS vendors Apr 13, 2015
@craigh craigh closed this as completed Mar 31, 2017
@Guite Guite reopened this Mar 31, 2017
@Guite
Copy link
Member

Guite commented Mar 31, 2017

How about removing the following ones, too:

  1. https://github.com/zikula/core/tree/master/src/javascript/jquery-plugins/jQuery-Timepicker-Addon
    -> not needed as the browser (or webshim polyfill) provides a time picker

  2. https://github.com/zikula/core/tree/master/src/javascript/plugins/colorbox
    -> we also include magnific popup as a lightbox solution https://github.com/dimsemenov/Magnific-Popup here https://github.com/zikula/core/blob/master/src/system/ThemeModule/composer.json#L25

  3. https://github.com/zikula/core/tree/master/src/javascript/plugins/jQuery-contextMenu
    -> Bootstrap context menus are more accessible and compatible with touch devices

@craigh craigh closed this as completed Mar 31, 2017
craigh added a commit that referenced this issue Dec 14, 2019
not sure why that ticket was closed without removing this lib.
But throwing errors now, so removing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants