Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap/prototype hide problem #1190

Closed
phaidon opened this issue Sep 23, 2013 · 5 comments
Closed

Bootstrap/prototype hide problem #1190

phaidon opened this issue Sep 23, 2013 · 5 comments
Milestone

Comments

@phaidon
Copy link
Contributor

phaidon commented Sep 23, 2013

If you load prototype and bootstrap there is a problem: Prototype lets disappear bootstrap elements. For example after you moved your mouse over bootstrap tooltip.

http://stackoverflow.com/questions/15087129/popover-hides-parent-element-if-used-with-prototype-js

@phaidon
Copy link
Contributor Author

phaidon commented Sep 23, 2013

twbs/bootstrap#8379

A workaround is replace hide.bs by bs:hide in bootstrap.min.js. I will make a pr to bootstrap, I hope it will accepted.

@phaidon
Copy link
Contributor Author

phaidon commented Sep 24, 2013

I suggest the following approach.

  1. Lets try to convince the bootstrap community to change this. But this function is in the bootstrap docs. So maybe they dont want to change this before 4.x or not all.
  2. If it wont be changed I suggest to remove the bootstrap bundle and to add a modified bootstrap version in the core. On this occasion we could chose a customized bootstrap version without glyphicons. This would also save performance.

@phaidon
Copy link
Contributor Author

phaidon commented Sep 28, 2013

I created a issue for a more a more individual event namespace: twbs/bootstrap#10848

ghost pushed a commit that referenced this issue Sep 28, 2013
Prototype-bootstrap compatibility workaround, closes #1190.
@sbuckpesch
Copy link

"twbs/bootstrap#8379

A workaround is replace hide.bs by bs:hide in bootstrap.min.js. I will make a pr to bootstrap, I hope it will accepted."
This solved my problem. Thanks phaidon

PS: BS 3.0.3, Prototype: 1.7 @ Magento 1.8.1

@espaan
Copy link
Contributor

espaan commented Aug 3, 2014

@phaidon does this mean the 1.4.x prototype - also the minified one - can be copied to 1.3.x as well for bootstrap stuff in 1.3.x ? Damn I see it is already in 1.3.x.

Im encountering this with zwebstore which uses bootstrap and tooltips. It should be solved with above fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants