Update signaling client (Azure#18068)

* update signaling client * format code * fix * update api view * keep the api same * format the code * add signaling client options * update signaling client * format code * fix * update api view * keep the api same * format the code * add signaling client options * fix package
zihzhan-msft · Oct 8, 2021 · 051d17f · 051d17f
1 parent 3304363
commit 051d17f
Show file tree

Hide file tree

Showing 6 changed files with 35 additions and 14 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/sdk/communication/communication-chat/CHANGELOG.md b/sdk/communication/communication-chat/CHANGELOG.md
@@ -1,6 +1,12 @@
 # Release History
 
-## 1.1.0 ((2021-09-15)
+## 1.1.1 (Not released)
+
+### Features Added
+- Updated to @azure/communication-signaling@1.0.0-beta.11.
+- Added `signalingClientOptions` in `ClientOptions`.
+
+## 1.1.0 (2021-09-15)
 
 ### Features Added
 

diff --git a/sdk/communication/communication-chat/package.json b/sdk/communication/communication-chat/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@azure/communication-chat",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Azure client library for Azure Communication Chat services",
   "sdk-type": "client",
   "main": "dist/index.js",
@@ -65,7 +65,7 @@
   "dependencies": {
     "@azure/abort-controller": "^1.0.0",
     "@azure/communication-common": "^1.1.0",
-    "@azure/communication-signaling": "1.0.0-beta.10",
+    "@azure/communication-signaling": "1.0.0-beta.11",
     "@azure/core-auth": "^1.3.0",
     "@azure/core-client": "^1.0.0",
     "@azure/core-rest-pipeline": "^1.1.0",

diff --git a/sdk/communication/communication-chat/src/chatClient.ts b/sdk/communication/communication-chat/src/chatClient.ts
@@ -85,7 +85,11 @@ export class ChatClient {
     const authPolicy = createCommunicationTokenCredentialPolicy(this.tokenCredential);
     this.client.pipeline.addPolicy(authPolicy);
 
-    this.signalingClient = getSignalingClient(credential, logger);
+    this.signalingClient = getSignalingClient(
+      credential,
+      logger,
+      (options as any).signalingClientOptions
+    );
   }
 
   /**
@@ -238,7 +242,7 @@ export class ChatClient {
     }
 
     this.isRealtimeNotificationsStarted = true;
-    this.signalingClient.start();
+    await this.signalingClient.start();
     this.subscribeToSignalingEvents();
   }
 
@@ -252,7 +256,7 @@ export class ChatClient {
     }
 
     this.isRealtimeNotificationsStarted = false;
-    this.signalingClient.stop();
+    await this.signalingClient.stop();
     this.emitter.removeAllListeners();
   }
 

diff --git a/sdk/communication/communication-chat/src/signaling/signalingClient.browser.ts b/sdk/communication/communication-chat/src/signaling/signalingClient.browser.ts
@@ -4,10 +4,14 @@
 import { CommunicationSignalingClient, SignalingClient } from "@azure/communication-signaling";
 import { CommunicationTokenCredential } from "@azure/communication-common";
 import { AzureLogger } from "@azure/logger";
+import { SignalingClientOptions } from "./signalingClient";
 
 export const getSignalingClient = (
   credential: CommunicationTokenCredential,
-  logger: AzureLogger
+  logger: AzureLogger,
+  options?: SignalingClientOptions
 ): SignalingClient | undefined => {
-  return new CommunicationSignalingClient(credential, logger);
+  return new CommunicationSignalingClient(credential, logger, {
+    environment: options?.environment ?? undefined
+  });
 };
diff --git a/sdk/communication/communication-chat/src/signaling/signalingClient.ts b/sdk/communication/communication-chat/src/signaling/signalingClient.ts
@@ -5,13 +5,20 @@ import { CommunicationSignalingClient, SignalingClient } from "@azure/communicat
 import { CommunicationTokenCredential } from "@azure/communication-common";
 import { AzureLogger } from "@azure/logger";
 
+export interface SignalingClientOptions {
+  environment?: string;
+}
+
 export const getSignalingClient = (
   credential: CommunicationTokenCredential,
-  logger: AzureLogger
+  logger: AzureLogger,
+  options?: SignalingClientOptions
 ): SignalingClient | undefined => {
   if (typeof navigator !== "undefined" && navigator.product === "ReactNative") {
     // In React Native
-    return new CommunicationSignalingClient(credential, logger);
+    return new CommunicationSignalingClient(credential, logger, {
+      environment: options?.environment ?? undefined
+    });
   }
 
   // In node js