Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the comptime interpreter #1980

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

Techatrix
Copy link
Member

@Techatrix Techatrix commented Jul 28, 2024

:(

EDIT:
Some people may wonder why I removed the comptime interpreter so here is an explanation:

The comptime interpreter has been added a long time ago by @SuperAuguste . Since its addition, it has never actively been worked on and never went beyond the proof-of-concept stage. I don't think that this has been publicly mention but I recall that SuperAuguste and me had agreed that there is not much motivation to keep it around.

I myself have also experimented with a potential solution to the "comptime in ZLS" problem. It can be found in the techatrix/stage2-sema branch. It is similar to the Zig compiler implementation because it uses the same intermediate representation of Zig code (ZIR). Unfortunately with all the active work on the compiler this branch frequently breaks and I currently do not have the time to continue working on it.

The good news is that the Zig is getting closer to implementing incremental compilation. Which would provide ZLS with faster build-on-save diagnostics. With the addition of ziglang/zig#615, ZLS could also be provided type information from the compiler.

Copy link
Member

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@Techatrix
Copy link
Member Author

🫡

@Techatrix Techatrix merged commit 8513557 into master Jul 28, 2024
3 checks passed
@Techatrix Techatrix deleted the techatrix/remove-comptime-interpreter branch July 28, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants