Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Giex GX03 Valve #3411

Merged
merged 10 commits into from
Oct 19, 2024
Merged

Add Giex GX03 Valve #3411

merged 10 commits into from
Oct 19, 2024

Conversation

prairiesnpr
Copy link
Contributor

@prairiesnpr prairiesnpr commented Oct 9, 2024

Proposed change

Add GIEX GX03 Quirk.

image

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (c4bbb68) to head (ef520e8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3411      +/-   ##
==========================================
+ Coverage   89.35%   89.36%   +0.01%     
==========================================
  Files         308      308              
  Lines        9978     9989      +11     
==========================================
+ Hits         8916     8927      +11     
  Misses       1062     1062              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prairiesnpr prairiesnpr force-pushed the giex-valve-03 branch 2 times, most recently from 9d8e527 to a725b64 Compare October 10, 2024 12:03
@prairiesnpr prairiesnpr marked this pull request as ready for review October 10, 2024 12:05
@TheJulianJES TheJulianJES added new quirk Adds support for a new device Tuya Request/PR regarding a Tuya device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. labels Oct 10, 2024
@prairiesnpr prairiesnpr mentioned this pull request Oct 12, 2024
3 tasks
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me then.

zhaquirks/tuya/ts0601_valve.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts0601_valve.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts0601_valve.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts0601_valve.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts0601_valve.py Outdated Show resolved Hide resolved
zhaquirks/tuya/ts0601_valve.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@TheJulianJES TheJulianJES merged commit 78b2c87 into zigpy:dev Oct 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quirk Adds support for a new device Tuya Request/PR regarding a Tuya device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants