Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to LocalDataCluster #3408

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Conversation

dmulcahey
Copy link
Collaborator

Proposed change

This PR adds logging to LocalDataCluster methods.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.71%. Comparing base (fa0d9fa) to head (7fe26ce).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/__init__.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3408      +/-   ##
==========================================
- Coverage   88.72%   88.71%   -0.02%     
==========================================
  Files         306      306              
  Lines        9813     9820       +7     
==========================================
+ Hits         8707     8712       +5     
- Misses       1106     1108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhaquirks/__init__.py Outdated Show resolved Hide resolved
zhaquirks/__init__.py Outdated Show resolved Hide resolved
zhaquirks/__init__.py Outdated Show resolved Hide resolved
zhaquirks/__init__.py Outdated Show resolved Hide resolved
@TheJulianJES TheJulianJES merged commit 7d81ef9 into dev Oct 10, 2024
5 of 7 checks passed
@TheJulianJES TheJulianJES deleted the dm/local-data-cluster-logging branch October 10, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants