-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove LevelControl cluster for IKEA INSPELNING plugs #3379
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3379 +/- ##
=======================================
Coverage 88.49% 88.49%
=======================================
Files 305 305
Lines 9621 9621
=======================================
Hits 8514 8514
Misses 1107 1107 ☔ View full report in Codecov by Sentry. |
Its the "personality" of all IKEA Zigbee 3.0+ devices then they is using remotes with level with On / Off then being direct paired with devices (tush link). By the way where did you getting the plug ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very OK for me.
@MattWestb Yeah, it's not on the website or in their "normal" system yet, but I asked at Wien Westbahnhof on Thursday, and they told me they get a shipment of 30pcs on Friday to be put into the shelves the same day. Sure enough they were there in the afternoon, as promised, so feel free to grab one while they last. :D Also, there's issue #3374 - Looks like we need to update the ac_power_divisor and consider it on power-value updates, see my last comment |
I was also at Wbh on Thursday but was not asking and need going on Monday if i can get time for getting some of them. |
Interesting testing you have done !! Ping our @puddly and @TheJulianJES !!! |
Is this attribute reportable? I wonder how the IKEA hubs avoids polling the attribute. |
@puddly Unfortunately don't have an IKEA hub, but tomorrow I'll try to check in the ZHA logs if I maybe can see the attribute being pushed by the plug automatically, where it maybe/hopefully just isn't evaluted by us yet. So far just been manually fetching/checking it for the first analysis of the issue: |
The attribute is apparently reportable according to the spec, we should just add it to the list of attributes to set up for reporting. I hope the device sends updates to that attribute first. Otherwise, the quirk will need logic to handle it. |
Thanks our @puddly for taking on look !! Thanks in advance !!! |
With the latest firmware is indeed reporting the (PS: only Puddly have my network key) |
PS: I think we shall moving the power factor out of this PR then its good ass it it and making one new PR / issue for the "dynamic power factor" implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(The ac_power_divisor
attribute stuff needs to be addressed separately in ZHA.)
The new smart plug suffers from the same issue like all IKEA plugs, unnecessary level controls in the configuration panel:

Proposed change
Expanded Quirk to be applied to new plug as well.
Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black