Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GIEX smart valve _TZE284_7ytb3h8u variant #3378

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

prairiesnpr
Copy link
Collaborator

Proposed change

Add GEIX Smart Valve Variant _TZE284_7ytb3h8u.

Additional information

Newer TUYA devices are adding an additional cluster 0xed00 this adds that variant. Manufacturer confirmed that this is working.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (d9c9df9) to head (fb1d617).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3378   +/-   ##
=======================================
  Coverage   88.49%   88.49%           
=======================================
  Files         305      305           
  Lines        9621     9625    +4     
=======================================
+ Hits         8514     8518    +4     
  Misses       1107     1107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Basic.cluster_id,
Groups.cluster_id,
Scenes.cluster_id,
TUYA_CLUSTER_ED00_ID,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note, this is not in the replacement. It doesn't really matter though, as there are no attributes on it (that we use) and I think that's in the manufacturer cluster range, so we'd need an (empty) CustomCluster.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Sep 24, 2024
@TheJulianJES TheJulianJES changed the title Add GIEX Smart Valve Var02 (_TZE284_7ytb3h8u) Add GIEX smart valve _TZE284_7ytb3h8u variant Sep 24, 2024
@TheJulianJES TheJulianJES merged commit d42d0d2 into zigpy:dev Sep 24, 2024
7 checks passed
@prairiesnpr prairiesnpr deleted the add-_TZE284_7ytb3h8u branch September 25, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants