Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Sinope files to new style AttributeDefs #3342

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

claudegel
Copy link
Contributor

@claudegel claudegel commented Sep 2, 2024

Proposed change

Update Sinope file format to new style AttributeDefs for thermostat.py, switch.py and sensor.py
Light.py is already modified in another PR #3313

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@claudegel
Copy link
Contributor Author

claudegel commented Sep 2, 2024

Can anybody explain what's wrong and how to fix please
Couldn't combine from non-existent path 'coverage*/.coverage*'

@TheJulianJES
Copy link
Collaborator

TheJulianJES commented Sep 2, 2024

It seems to be an issue with our CI at the moment, don't worry about it for now.
EDIT: Fixed now.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (5c4e08d) to head (c0a0570).
Report is 16 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3342      +/-   ##
==========================================
+ Coverage   88.48%   88.61%   +0.13%     
==========================================
  Files         305      305              
  Lines        9623     9736     +113     
==========================================
+ Hits         8515     8628     +113     
  Misses       1108     1108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudegel
Copy link
Contributor Author

Thank's

@TheJulianJES TheJulianJES added code quality Improvement to code quality needs review This PR should be reviewed soon, as it generally looks good. labels Sep 16, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Hopefully didn't miss anything 😅

@TheJulianJES TheJulianJES merged commit e749877 into zigpy:dev Sep 24, 2024
7 checks passed
@claudegel claudegel deleted the New-style branch September 25, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality needs review This PR should be reviewed soon, as it generally looks good.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants