-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Sinope files to new style AttributeDefs #3342
Conversation
Can anybody explain what's wrong and how to fix please |
It seems to be an issue with our CI at the moment, don't worry about it for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3342 +/- ##
==========================================
+ Coverage 88.48% 88.61% +0.13%
==========================================
Files 305 305
Lines 9623 9736 +113
==========================================
+ Hits 8515 8628 +113
Misses 1108 1108 ☔ View full report in Codecov by Sentry. |
Thank's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Hopefully didn't miss anything 😅
Proposed change
Update Sinope file format to new style AttributeDefs for thermostat.py, switch.py and sensor.py
Light.py is already modified in another PR #3313
Additional information
Checklist
pre-commit
checks pass / the code has been formatted using Black