Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt v2 quirks to new zigpy API #3280

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

TheJulianJES
Copy link
Collaborator

@TheJulianJES TheJulianJES commented Aug 2, 2024

Proposed change

The latest zigpy version changes the quirks v2 API to use QuirkBuilder instead of add_to_registry_v2.
A call to quirkBuilder.add_to_registry() at the end is also required now.

This PR adapts the three existing v2 quirks to the new API.
The zigpy requirement is also bumped to 0.65.2.

Additional information

Related zigpy PR:

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

pyproject.toml Outdated Show resolved Hide resolved
requirements_test.txt Outdated Show resolved Hide resolved
@dmulcahey
Copy link
Collaborator

dmulcahey commented Aug 3, 2024

Whelp I didn't see your comment... and I released as a minor... https://github.com/zigpy/zigpy/releases/tag/0.65.1 Found a small bug. Will be 0.65.2: https://github.com/zigpy/zigpy/releases/tag/0.65.2

@dmulcahey
Copy link
Collaborator

Here is the PR to the ZHA lib if you wanna bump this in there once everything is updated / released

pyproject.toml Outdated Show resolved Hide resolved
requirements_test.txt Outdated Show resolved Hide resolved
@TheJulianJES TheJulianJES marked this pull request as ready for review August 3, 2024 20:36
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.18%. Comparing base (e3c115e) to head (2790137).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3280   +/-   ##
=======================================
  Coverage   88.18%   88.18%           
=======================================
  Files         301      301           
  Lines        9412     9412           
=======================================
  Hits         8300     8300           
  Misses       1112     1112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 54bed86 into zigpy:dev Aug 3, 2024
6 checks passed
danielp370 pushed a commit to danielp370/zha-device-handlers that referenced this pull request Aug 25, 2024
* Use new zigpy quirks v2 API

* Bump requirements to zigpy 0.65.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants