-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tuya TY0201 temperature/humidity sensor #3201
Conversation
b1747b4
to
a3840e3
Compare
This seems to be a pretty common sensor, for which several models seem to exist : _TZ3000_bjawzodf and _TZ3000_zl1kmjqx Fixes: zigpy#2862, zigpy#2851, zigpy#2701 Signed-off-by: Philippe De Swert <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3201 +/- ##
==========================================
+ Coverage 88.17% 88.18% +0.01%
==========================================
Files 300 301 +1
Lines 9386 9396 +10
==========================================
+ Hits 8276 8286 +10
Misses 1110 1110 ☔ View full report in Codecov by Sentry. |
Hi @philippedeswert, thanks for the contribution. Thanks in advance. |
I'll give it a try. Do I update this PR or is it better to make a new one if I get it working with v2? |
It's fine to update this PR, but whatever you feel confortable will be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We can change this to a v2 quirk in the future.
For now, this should be good to go.
This seems to be a pretty common sensor, for which several models seem to exist : _TZ3000_bjawzodf and _TZ3000_zl1kmjqx
Proposed change
Add support for another humidity/temperature sensor
Additional information
First time contributing here. And I am not sure it is completely correct, but
this quirk is confirmed to work for a wide number of people. I welcome any comments
to improve this.
Fixes #2862, fixes #2851, fixes #2701
Checklist
pre-commit
checks pass / the code has been formatted using Black