Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Aqara H1 wireless double rocker variants #3169

Merged

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

This adds two more signatures for the Aqara H1 wireless double rocker switches.
They're all inheriting from RemoteH1DoubleRocker1 now (for device triggers and replacement).

Hopefully, we can improve this with quirks v2 in the future. These changes are already tested in #940 and by myself though.
So, it's easier to add them in for now. Also note that the replacement is the same for all variants.

Additional information

Should fix #940

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added the Xiaomi Request/PR regarding a Xiaomi device label May 26, 2024
Copy link

codecov bot commented May 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (21dd8eb) to head (aaf5059).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3169   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         299      299           
  Lines        9389     9392    +3     
=======================================
+ Hits         8276     8279    +3     
  Misses       1113     1113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the smash This PR is close to be merged soon label May 28, 2024
@TheJulianJES TheJulianJES merged commit c6ed94a into zigpy:dev May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smash This PR is close to be merged soon Xiaomi Request/PR regarding a Xiaomi device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Aqara H1 wireless switch double rocker (model WRS-R02)
1 participant