Add Tuya smoke detector TS0205 PST-YG500A

[cdalexndr]

Proposed change

Additional information

Removed useless Opening sensor.
Changed motion sensor to smoke sensor.

Checklist

• The changes are tested and work correctly
• pre-commit checks pass / the code has been formatted using Black
• Tests have been added to verify that the new code works

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (daef394) to head (a136a0e).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #2991      +/-   ##
==========================================
+ Coverage   88.27%   88.30%   +0.02%     
==========================================
  Files         302      303       +1     
  Lines        9447     9471      +24     
==========================================
+ Hits         8339     8363      +24     
  Misses       1108     1108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TheJulianJES]

Thanks for the PR! I've added some suggestions.
Ideally, we should also add a test for the actual code (that translates the Tuya attribute to the IasZone attribute).

This test can mostly be copied IMO:

zha-device-handlers/tests/test_xiaomi.py

Lines 781 to 809 in e4d0663

	@pytest.mark.parametrize("quirk", (zhaquirks.xiaomi.aqara.smoke.LumiSensorSmokeAcn03,))
	async def test_aqara_smoke_sensor_attribute_update(zigpy_device_from_quirk, quirk):
	"""Test update_attribute on Aqara smoke sensor."""
	device = zigpy_device_from_quirk(quirk)
	opple_cluster = device.endpoints[1].opple_cluster
	opple_listener = ClusterListener(opple_cluster)
	ias_cluster = device.endpoints[1].ias_zone
	ias_listener = ClusterListener(ias_cluster)
	zone_status_id = IasZone.AttributeDefs.zone_status.id
	# check that updating Xiaomi smoke attribute also updates zone status on the Ias Zone cluster
	# turn on smoke alarm
	opple_cluster.update_attribute(0x013A, 1)
	assert len(opple_listener.attribute_updates) == 1
	assert len(ias_listener.attribute_updates) == 1
	assert ias_listener.attribute_updates[0][0] == zone_status_id
	assert ias_listener.attribute_updates[0][1] == IasZone.ZoneStatus.Alarm_1
	# turn off smoke alarm
	opple_cluster.update_attribute(0x013A, 0)
	assert len(opple_listener.attribute_updates) == 2
	assert len(ias_listener.attribute_updates) == 2
	assert ias_listener.attribute_updates[1][0] == zone_status_id
	assert ias_listener.attribute_updates[1][1] == 0

The opple cluster stuff just needs to be changed to the Tuya stuff (and the quirk path needs to be changed).
If you need help with adding this test, let me know and I'll add it, as soon as I have some time.

[mr-bembel]

Hello,

Are there any news to support the product in ZHA soon? I bought 4 of them...

[Fr33L4nc3r]

@cdalexndr Seems the pipeline failed at pre-commit step. Since you fixed it in the past (fa98480), any chance you could have a look again ?
It seems like there ain't much to have this PR approved (despite the change request still appearing in red, while it seemed addressed with dcd03eb).

Looking forward to see this device recognized correctly and automatically in zha thanks to amazing community work like yours.

[TheJulianJES]

Thanks, I think this should be fine.

[abmantis]

@cdalexndr why is the TuyaSmokeDetectorCluster needed? The sensor worked fine previously, it would just show motion instead of smoke as the sensor type, but that is be fixed with just the addition of the TuyaIasZone cluster on line 57. So, why the extra TuyaSmokeDetectorCluster cluster?

[Fr33L4nc3r]

Just received a Product Safety Recall mail from Aliexpress about this smoke detector, just sharing in case you didn't know, I know what I need to replace ASAP :/