-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring transmit power on TI Z-Stack routers #1886
Allow configuring transmit power on TI Z-Stack routers #1886
Conversation
Pull Request Test Coverage Report for Build 3390045545
💛 - Coveralls |
Codecov ReportBase: 82.78% // Head: 82.80% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1886 +/- ##
==========================================
+ Coverage 82.78% 82.80% +0.02%
==========================================
Files 243 244 +1
Lines 7544 7555 +11
==========================================
+ Hits 6245 6256 +11
Misses 1299 1299
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
NIce, I actually just flashed a router a few minutes ago to look at this. Honestly not sure I will be continuing to compile my own fw. |
Should I remove your model ID from the signature for now? (can also be added back later of course) |
Yeah, remove it for now. thanks! |
Quirk works for me🎉 |
FYI, the premium version of PTVO Zigbee Configurable Firmware has the same function when built Zigbee Router firmware for CC2652P and CC1352P with it and enable its ”RF signal level” sensor -> https://ptvo.info/zigbee-configurable-firmware-features/rf-signal-level-control/
|
I have HA 2023.4.4 but I don't see transmit_power for my Sonoff CC2652P - is this expected? |
@ErikApption Make sure you're running a somewhat recent Z-Stack router release on that stick. |
I do have last week's firmware installed but I did install the firmware after configuring the radio. How would I re-pair? Would this be a migrate radio thing? |
This PR is for configuring transmit power on Z-Stack routers, not coordinators. If you want to change transmit power for your coordinator, then have a look at the zigpy repo. |
Ohhhhh thanks for the clarification!!! I missed that detail. I did see yaml for changing transmit power on coordinator for zigbee2mqtt but haven't been able to trace the details for HA |
Check this: https://github.com/zigpy/zigpy-znp#configuration Only paste in the first couple of rows that you actually need. Most of the times, you shouldn't really increase transmit power though, as it'll only "shout louder", but won't hear other devices better. |
Changes
Z-Stack router firmware
20221102
and above adds atransmit_power
attribute on theBasic cluster
.This quirk makes that attribute accessible through ZHA.
I also addedTubesZB
/tubeszb.router
to the signature, even though it doesn't support the configurable attribute yet, but I'm sure he'll add it in the future. cc @tube0013 (still on the Z-Stackdev
branch as of right now though)Edit: It's possible that no new updates will be made for "TubesZB" custom router firmware and as current versions don't support the configurable attribute, I removed it from the signature entirely.
(A config entity in ZHA could also be added. For older versions, a
warningdebug message will be printed on startup saying that the attribute isn't supported for routers running older firmware.)(PR for ZHA config entity: home-assistant/core#81520)
Closes #1884
Z2M converter commit: Koenkk/zigbee-herdsman-converters@8fb1ba4
Z-Stack
firmware.patch
commit: Koenkk/Z-Stack-firmware@3d43a50Z-Stack issue: Koenkk/Z-Stack-firmware#341
The quirk is tested and works.
Testing
This quirk will likely be available in Home Assistant 2022.12.0 or later.
If you want to test it now, download the router.py file and put it in your configured
custom_zha_quirks
directory. Then, restart Home Assistant.For now, you can change the transmit power using the "Manage Zigbee Device" UI -> "Clusters".
Select
BasicCluster
andtransmit_power
. Then, you can read the attribute. If your firmware supports it, it'll return a number (like5
or9
). If your firmware is still unsupported, it'll returnNone
and you'll need to update your router firmware.To change the transmit power, simply replace the number in the upper text field (leave the lower text field empty) and then click "Set Zigbee attribute". You can re-read the attribute to verify that the change worked.
Also, make sure to remove the custom quirk as soon as it's merged into Home Assistant.