Wrap send_fut in a timeout #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmulcahey
approved these changes
Mar 1, 2019
|
Please merge after PR #150 |
Adminiuga
force-pushed
the
fixes/124-send-wait-timeout
branch
from
ddb1145 to
c43d68a
Compare
Adminiuga
force-pushed
the
fixes/124-send-wait-timeout
branch
from
c43d68a to
ef4a7ea
Compare
Adminiuga
force-pushed
the
fixes/124-send-wait-timeout
branch
from
ef4a7ea to
74bba8f
Compare
|
@damarco this is rebased and ready for the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use timeout when awaiting for a
messageSentcallback. Targeted as a partial fix for #124Please merge PR #147 1st and I'll rebase this one.