Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage1: remove outdated error message regarding #447 #8688

Merged
merged 1 commit into from
May 10, 2021

Conversation

g-w1
Copy link
Contributor

@g-w1 g-w1 commented May 4, 2021

Closes #8687.
Hopefully this saves some memory!

Copy link
Member

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also need to be removed from the grammar: https://github.com/ziglang/zig-spec/blob/ad3d1ad35bb016b27a524b9cf1b1e365609079c9/grammar/grammar.y#L23
and from this comment in the self hosted parser:

/// FnProto <- KEYWORD_fn IDENTIFIER? LPAREN ParamDeclList RPAREN ByteAlign? LinkSection? CallConv? EXCLAMATIONMARK? (Keyword_anytype / TypeExpr)

Copy link
Member

@ifreund ifreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@ifreund ifreund merged commit 24dfa61 into ziglang:master May 10, 2021
@ifreund
Copy link
Member

ifreund commented May 10, 2021

Updated the spec grammar as well: ziglang/zig-spec@a47c641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update error message regarding #447
2 participants