-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stage2: catch at comptime! #7628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-w1
force-pushed
the
stage2-check-errs
branch
from
January 1, 2021 01:01
49d9b19
to
d92189d
Compare
This was referenced Jan 3, 2021
Closed
g-w1
force-pushed
the
stage2-check-errs
branch
3 times, most recently
from
January 19, 2021 03:56
e1930f2
to
d80ce37
Compare
g-w1
changed the title
stage2: error union unwrapping checking
stage2: catch at comptime!
Jan 19, 2021
Vexu
reviewed
Jan 29, 2021
g-w1
force-pushed
the
stage2-check-errs
branch
6 times, most recently
from
January 31, 2021 00:08
f8a4d00
to
c612054
Compare
Vexu
reviewed
Jan 31, 2021
g-w1
force-pushed
the
stage2-check-errs
branch
2 times, most recently
from
February 1, 2021 12:02
e896459
to
2c71fe9
Compare
Vexu
requested changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nearly ready to go.
g-w1
force-pushed
the
stage2-check-errs
branch
from
February 3, 2021 19:29
2c71fe9
to
43aa51e
Compare
Is there anything else I can do? |
Vexu
reviewed
Feb 17, 2021
* add error_union value tag. * add analyzeIsErr * add Value.isError * add TZIR wrap_errunion_payload and wrap_errunion_err for wrapping from T -> E!T and E -> E!T * add anlyzeInstUnwrapErrCode and analyzeInstUnwrapErr * add analyzeInstEnsureErrPayloadVoid: * add wrapErrorUnion * add comptime error comparison for tests * tests!
g-w1
force-pushed
the
stage2-check-errs
branch
from
February 17, 2021 21:11
43aa51e
to
ebea8ba
Compare
Vexu
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve stage2 to allow catch at comptime:
wrapping from T -> E!T and E -> E!T