stage2: add compile log statement #7191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
added
the
frontend
Vexu
requested changes
Nov 22, 2020
|
As a temporary solution, Ill just make it print to stderr instead of using the mod.fail so that a decl can have other errors too. |
…t gets displayed so the binary still gets produced
g-w1
force-pushed
the
stage2-compile-log
branch
from
1db5e91 to
3a7c08e
Compare
|
Just saw your comment on #7239 about this, the reason it was ok to just use ArrayListUnmanaged(usize) was because the error message for a |
…ge s instead of a Module.compile_log_decls field
|
Making this a draft until #7239 gets solved because it is very hard to debug this. |
… bug is stopping me from really doing anything, cleaned up a little
5 tasks
g-w1
force-pushed
the
stage2-compile-log
branch
from
c62380a to
9f75473
Compare
Vexu
approved these changes
Dec 25, 2020
andrewrk
reviewed
Dec 28, 2020
| self.bin_file.updateDecl(module, decl) catch |err| { | ||
| switch (err) { | ||
| error.OutOfMemory => return error.OutOfMemory, | ||
| error.AnalysisFail => { | ||
| decl.analysis = .dependency_failure; | ||
| }, | ||
| else => { | ||
| try module.failed_decls.ensureCapacity(module.gpa, module.failed_decls.items().len + 1); | ||
| module.failed_decls.putAssumeCapacityNoClobber(decl, try ErrorMsg.create( | ||
| try module.addDeclErr(decl, try ErrorMsg.create( |
There was a problem hiding this comment.
Every instance of this change introduced a memory leak if ErrorMsg.create fails.
andrewrk
added a commit
that referenced
this pull request
Dec 28, 2020
The addition of `addDeclErr` introduced a memory leak at every call site, and I also would like to push back on having more than 1 compilation error per `Decl`. This reverts commit 1634d45.
aarvay
pushed a commit
to aarvay/zig
that referenced
this pull request
Jan 4, 2021
aarvay
pushed a commit
to aarvay/zig
that referenced
this pull request
Jan 4, 2021
The addition of `addDeclErr` introduced a memory leak at every call site, and I also would like to push back on having more than 1 compilation error per `Decl`. This reverts commit 1634d45.
dgbuckley
pushed a commit
to dgbuckley/zig
that referenced
this pull request
Mar 9, 2021
dgbuckley
pushed a commit
to dgbuckley/zig
that referenced
this pull request
Mar 9, 2021
The addition of `addDeclErr` introduced a memory leak at every call site, and I also would like to push back on having more than 1 compilation error per `Decl`. This reverts commit 1634d45.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only problem that I ran into making this pr was that the output of the
@compilelogcan't be tested. There is no way to test compile-time output besides errors. Should this be added just to enable compile logging testing?