Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage1: implement --full-name #6317

Closed
wants to merge 1 commit into from
Closed

Conversation

ifreund
Copy link
Member

@ifreund ifreund commented Sep 11, 2020

This allows overriding the output name of the resulting binary, including the lib prefix for libraries and the extension.

This is necessary, for example, when creating a shared library for use as a plugin, in which case specific naming conventions must be followed.

Closes #2231
This does not yet expose this feature in the zig build system, that will be implemented in a follow up PR if this one is accepted

This allows overriding the output name of the resulting binary,
including the lib prefix for libraries and the extension.

This is necessary, for example, when creating a shared library for
use as a plugin, in which case specific naming conventions must
be followed.
@daurnimator
Copy link
Contributor

Should there be an error if both --name and --full-name are set?

@ifreund
Copy link
Member Author

ifreund commented Sep 11, 2020

Should there be an error if both --name and --full-name are set?

Not opposed, but not sure if it's really needed. The current behavior of --full-name overriding --name makes sense IMO.

@ifreund
Copy link
Member Author

ifreund commented Sep 11, 2020

It's worth noting that for my particular use case, overriding the prefix applied to the name alone would be sufficient when combined with #6315. Perhaps this option should keep the default extension and only override the lib prefix, as then produced binaries would still have the "proper" extension based on the target.

@ifreund
Copy link
Member Author

ifreund commented Sep 11, 2020

Looks like this is already implemented in #6250, no point in implementing this in stage1

@ifreund ifreund closed this Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Way to set shared library filename
2 participants