compiler-rt: Add the __atomic family of builtins #4924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation was checked against a few files using std::atomic and compiled using zig c++. Closes ziglang#4887
LemonBoy
force-pushed
the
compiler-rt-atomics
branch
from
f1eb275
to
e7e7c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation was checked against a few files using std::atomic and
compiled using zig c++.
The results are ok on ARM32 and mipsel.
No 128 bit variants yet, I prefer to add those if/when they're effectively spotted in the wild.
I had to cut down the comptime trickery because it became a mess pretty quickly, feel free to re-add some bits as/if needed.
Refer to this GCC page when reviewing.
Closes #4887