Updates and cleanup in self hosted compiler

[Vexu]

Changes

• use enum literals
• remove await (async .. catch unreachable) pattern
• cleanup target.zig into util.zig and use std.Target
• update use of std.event

TODO after this

• update std.event.fs
• review and update use of async functions

[andrewrk]

Nice work!

Due to #3190 this patch is needed to compile.

Can you go ahead and make this workaround, with a TODO comment linking to that issue, to remind us to remove the workaround when the issue is fixed?

[andrewrk]

Does this get it building again successfully? If so we could re-enable building it as part of the test suite:

zig/build.zig

Lines 75 to 78 in 29d7b5a

	if (!skip_self_hosted) {
	// TODO re-enable this after https://github.com/ziglang/zig/issues/2377
	//test_step.dependOn(&exe.step);
	}

[Vexu]

Does this get it building again successfully? If so we could re-enable building it as part of the test suite:

zig/build.zig

Lines 75 to 78 in 29d7b5a

	if (!skip_self_hosted) {
	// TODO re-enable this after https://github.com/ziglang/zig/issues/2377
	//test_step.dependOn(&exe.step);
	}

It should.

[Vexu]

It should.

Apparently only on Linux. Can someone on Mac or Windows give detailed error logs?

[andrewrk]

Apparently only on Linux. Can someone on Mac or Windows give detailed error logs?

I can help you with that in a bit. If you click on the "Details" link in the CI above, do you see the error? It should be open access with no login required.

[andrewrk]

Oh, I can tell you what's going on here though. Evented I/O mode integration isn't hooked up with non-Linux operating systems yet. Specifically, the waitUntilFdIsReadable and related functions don't have non-Linux implementations yet.

It would still be helpful to enable building the self-hosted compiler as part of the test suite when the target is Linux though. That's still more test coverage than before, as we work towards full coverage and full support.

[andrewrk]

Oh, nice you even got the stage2 tests passing again. I'm guessing for the Windows failure, this code will need to chop off the extra .lib in the library names that we get from llvm-config:

zig/build.zig

Lines 229 to 242 in 29d7b5a

	{
	var it = mem.tokenize(libs_output, " \r\n");
	while (it.next()) |lib_arg| {
	if (mem.startsWith(u8, lib_arg, "-l")) {
	try result.system_libs.append(lib_arg[2..]);
	} else {
	if (fs.path.isAbsolute(lib_arg)) {
	try result.libs.append(lib_arg);
	} else {
	try result.system_libs.append(lib_arg);
	}
	}
	}
	}

I'd be happy to help with this; I have a Windows machine sitting right over here.

[andrewrk]

I don't think the stage2 tests are ready to be resurrected yet, if you look at src-self-hosted/test.zig, it creates its own event loop, and tries to do evented I/O, but zig test doesn't support that yet, so it's this weird mixture of evented and blocking (which amazingly apparently did work successfully on Linux and macOS (or maybe not, I see "stage2...SKIP" in the log output)