Adds imported ZON files to the cache manifest #22750
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22746
Someone more familiar with the way caching works than me should probably take a quick look at this before it's merged, I only just looked at this part of the codebase for the first time while writing this.
In particular:
I'm using
addFilePost
. I picked this because it's the most similar to what embed file does but doesn't require the file contents, but maybe it's not the right option.I'm unsure about the way I handle the errors that
addFilePost
can return. Other places in this file seem to have a TODO and just call sema.fail in similar circumstances, so I've done that here, but I feel a little bad proliferating the TODO without understanding it.