Watch: Create fanotify per mount_id #20672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayrod246
reviewed
Jul 18, 2024
| @@ -14,14 +14,16 @@ generation: Generation, | |||
| /// interested in noticing changes to. | |||
| /// | |||
| /// Value is generation. | |||
| const DirTable = std.ArrayHashMapUnmanaged(Cache.Path, void, Cache.Path.TableAdapter, false); | |||
| const DirTable = std.ArrayHashMapUnmanaged(Cache.Path, MountId, Cache.Path.TableAdapter, false); | |||
There was a problem hiding this comment.
I think that because this is a Linux-specific change, that this is the wrong place to add MountId and should instead be moved inside the Linux-specific Os struct defined below in this file.
For example, I use DirTable in this windows implementation where this MountId wouldn’t be needed.
There was a problem hiding this comment.
Indeed, I will make that adjustment prior to merging. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very naive implementation, but it seems to be working fine.
Fixes #20670