Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sema: prevent comptime-mutable pointers leaking into runtime code #14974

Closed
wants to merge 1 commit into from

Conversation

mlugg
Copy link
Member

@mlugg mlugg commented Mar 17, 2023

Resolves: #10920

@mlugg
Copy link
Member Author

mlugg commented Mar 17, 2023

i don't really get why this is failing, the code that's erroring shouldn't have anything comptime-mutable whatsoever. will look at it tomorrow

@mlugg
Copy link
Member Author

mlugg commented Mar 19, 2023

This is blocked on the decaying of decl_ref_mut values to decl_refs when the decl goes out of scope. I'll try and implement that soon, excited to inadvertently break everyone's bad comptime code :)

For the time being, I'll mark this as a draft so maintainers know they don't need to look at it.

@mlugg mlugg marked this pull request as draft March 19, 2023 12:33
@andrewrk
Copy link
Member

Closing abandoned draft

@andrewrk andrewrk closed this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stage1: miscompilation on writing with comptime-computed offsets into comptime constructed buffer
2 participants