wasm-linker: emit build_id section #14820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewrk
requested changes
Mar 6, 2023
There was a problem hiding this comment.
Please check the value of wasm.base.options.build_id and use that to determine whether to emit a build ID. If you wish to change the default of whether build ids are enabled or disabled, that code lives in Compilation.create.
Please also ensure that the build id makes it into the wasm linker hash, now that this option affects the output. Alternately, ensure that incremental linking notices a change in the build id flag and modifies the output appropriately. For many settings this is already the case since the header is flushed unconditionally.
|
You beat me to it. Nice work Frank! |
Luukdegram
previously requested changes
Mar 7, 2023
Luukdegram
approved these changes
Mar 7, 2023
The Build ID is a value that uniquely identifies a build. It is intended to capture the "meaning" or inputs of the build, and is usually associated with debug info. Reference: https://github.com/WebAssembly/tool-conventions/blob/main/BuildId.md
Also use TurboSHAKE instead of BLAKE3 now that we have it.
truemedian
pushed a commit
to truemedian/zig
that referenced
this pull request
Mar 30, 2023
The Build ID is a value that uniquely identifies a build. It is intended to capture the "meaning" or inputs of the build, and is usually associated with debug info. Reference: https://github.com/WebAssembly/tool-conventions/blob/main/BuildId.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make our wasm linker emit the build ID, a value that uniquely identifies a build.
It is intended to capture the "meaning" or inputs of the build, and is usually associated with debug info.
References:
Support for this was also recently added to LLVM: llvm/llvm-project@c7af9ae