langref: document extern variadic functions #13902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
reviewed
Dec 12, 2022
doc/langref.html.in
Outdated
| try testing.expect(@typeInfo(@TypeOf(printf)).Fn.is_var_args); | ||
| } | ||
| {#code_end#} | ||
| <p>Non extern variadic functions are not allowed.</p> |
There was a problem hiding this comment.
Non-extern variadic functions are an accepted proposal #515
There was a problem hiding this comment.
I was aware of #515; do you think that I should add a link to the issue?
There was a problem hiding this comment.
It shouldn't say that they are not allowed, linking the issue and saying it hasn't been implemented would be better.
There was a problem hiding this comment.
Thanks.
By the way: is it correct to do a git commit --amend followed by git push --force-with-lease ?
There was a problem hiding this comment.
Yes, but you can also just push more commits if you want and then the PR can be squash merged.
Add a new subsection within the C section, documenting extern variadic functions.
perillo
force-pushed
the
langref-document-variadic-functions
branch
from
a5617b0 to
9996dc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new subsection within the C section, documenting extern variadic functions.