std: Replace use of stage1 function pointers #12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matu3ba
reviewed
Sep 6, 2022
There was a problem hiding this comment.
Relevant search entries (escaping missing): grep 'builtin.zig_backend', grep '.stage1', grep ': fn (', grep '*const fn (', grep '*fn ('
- The alignment is also missing in a few other places.
- Can you comment on where alignment is necessary and where not? I do see
align(8)andalign(1)in a couple of places. Might be worth double checking those for ABI problems, when there are many eyes on this change anyway.
|
related: #12813 |
|
This should be ready to merge, I'll just rebase to get the checks to run correctly. |
ominitay
force-pushed
the
fix-function-pointers
branch
from
e8699ce to
10c76e3
Compare
|
Looks like I missed a few function pointers for Windows, will fix them. |
ominitay
force-pushed
the
fix-function-pointers
branch
3 times, most recently
from
a0b47b3 to
bf23dde
Compare
|
Tests passing, ready to be merged. |
|
Found a couple of mistakes in this PR, and also a merge conflict, will get those fixed. Please merge soon! |
ominitay
force-pushed
the
fix-function-pointers
branch
from
bf23dde to
f752dee
Compare
|
@andrewrk Can this be merged before it goes stale again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many parts of
stdstill use stage1-style function pointers. This PR removes all instances of this, replacing them with the use ofstd.meta.FnPtr. Additionally, manually-writtenifstatements have been replaced withFnPtrfor clarity, conciseness, and to be guarantee detection and removal when stage1 support is removed fromstd.I'll give this another check over before it's ready to merge.