-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows async networking #10115
Windows async networking #10115
Conversation
* uses accept flag to select windows accept function
Thanks.. i dont found your branch/PR - and implement it (first-try experimental) in the same way by myself. |
I was unhappy with the quality and possible future maintenance of code, for example GetQueuedCompletionStatus ignoring all errors which could be considered an antipattern for the current design of std. There're also multiple assumptions of socket and connection proto |
GetQueuedCompletionStatus
logickernel32.GetFileType
function andFileType
enum, for fd checkingWSA_FLAG_OVERLAPPED
to socket if requestingSOCK.NONBLOCK
in windowsio_mode
is.evented
WriteFile
andReadFile
for sockets, by ignoringoffset
andSetFilePointerEx
calls if fd is a pipe devicewindows.acceptEx
fromos.accept
ifio_mode
is.evented