Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"options: error: AccessDenied" race on Windows with build options post #14647 #15063

Open
scheibo opened this issue Mar 24, 2023 · 4 comments
Open
Labels
bug Observed behavior contradicts documented or intended behavior os-windows
Milestone

Comments

@scheibo
Copy link
Contributor

scheibo commented Mar 24, 2023

Zig Version

0.11.0-dev.2247+38ee46dda

Steps to Reproduce and Observed Behavior

I'm assuming Windows needs something similar to the solution for macOS from #15006

$ git clone https://github.com/pkmn/engine.git
$ zig -Dshowdown=false tools -p build

Note: this doesn't seem to fail consistently - it has failed on the GitHub CI on 1/4 windows runs the last two times ive pushed and then when the job is retried it succeeds. https://github.com/pkmn/engine/actions/runs/4506104662/jobs/7932535027

options: error: unable to rename options from 'D:\a\engine\engine\zig-cache\tmp\67ec2197bc57191a\options.zig' to 'D:\a\engine\engine\zig-cache\c\fb49e8bc5ba2181c23673c24abe88e66\options.zig': AccessDenied
Build Summary: 9/[14](https://github.com/pkmn/engine/actions/runs/4506104662/jobs/7932535027#step:13:15) steps succeeded; 1 failed (disable with -fno-summary)
tools transitive failure
+- Install tools transitive failure
   +- install benchmark transitive failure
   |  +- zig build-exe benchmark ReleaseFast native transitive failure
   |     +- options failure
   +- install fuzz success
   |  +- zig build-exe fuzz Debug native success 2s
   |     +- options success
   +- install serde success
   |  +- zig build-exe serde Debug native success 2s
   |     +- options cached
   +- install protocol success
      +- zig build-exe protocol Debug native success 3s
         +- options cached

Expected Behavior

No error :)

@scheibo scheibo added the bug Observed behavior contradicts documented or intended behavior label Mar 24, 2023
scheibo added a commit to pkmn/engine that referenced this issue Mar 24, 2023
@scheibo
Copy link
Contributor Author

scheibo commented Mar 24, 2023

#8362 possibly related?

@andrewrk andrewrk added this to the 0.11.0 milestone Apr 10, 2023
scheibo added a commit to pkmn/engine that referenced this issue May 16, 2023
@scheibo
Copy link
Contributor Author

scheibo commented May 18, 2023

This is possibly fixed - I haven't seen it repro after 0.11.0-dev.3132 (possible #15641 fixed this?). If i see this crop up again I will reopen/try to get a more usable reproduction.

@scheibo scheibo closed this as completed May 18, 2023
scheibo added a commit to pkmn/engine that referenced this issue May 23, 2023
@scheibo scheibo reopened this May 23, 2023
@scheibo
Copy link
Contributor Author

scheibo commented May 23, 2023

OK so this still repros (though less frequently?) https://github.com/pkmn/engine/actions/runs/5052518703/jobs/9065449621

Don't really have a nice friendly minimal set up for this beyond the initial description. nor do i know if the fact that is seems to be consistently failing on the build options package is relevant

@motiejus
Copy link
Contributor

motiejus commented Jun 20, 2023

Windows-specific issue is probably related to #14978

@andrewrk andrewrk modified the milestones: 0.11.0, 0.11.1 Jul 22, 2023
@andrewrk andrewrk modified the milestones: 0.11.1, 0.12.0, 0.13.0 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Observed behavior contradicts documented or intended behavior os-windows
Projects
None yet
Development

No branches or pull requests

3 participants