stage2: if allows usize in condition, if the payload is discarded

[topolarity]

Zig Version

0.10.0-dev.4189+17eea918a

Steps to Reproduce

test {
    if (@as(usize, 5)) |_| {}
}

Expected Behavior

Stage 1 does the right thing:

./test.zig:3:9: error: expected optional type, found 'usize'
    if (@as(usize, 5)) |_| {
        ^

Actual Behavior

All 1 tests passed.

[nektro]

this is because of the @as not usize

[nektro]

its not doing the optional check when the payload is a builtin. the following has the same result

test {
    if (@sin(5.0)) |_| {}
}

[Vexu]

This issue also applies to error union conditions and while loops and has nothing to do with builtin functions and everything to do with is_non_err and is_non_null being valid for all types.