Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make the static linux binary link return non-301 status code #1046

Closed
andrewrk opened this issue Jun 4, 2018 · 4 comments
Closed

CI: make the static linux binary link return non-301 status code #1046

andrewrk opened this issue Jun 4, 2018 · 4 comments
Milestone

Comments

@andrewrk
Copy link
Member

andrewrk commented Jun 4, 2018

The linux static build download link is getting cached in users' browsers.

Looks like it's possible using "Advanced Conditional Redirects" https://docs.aws.amazon.com/AmazonS3/latest/dev/how-to-page-redirect.html#advanced-conditional-redirects

HttpRedirectCode

@andrewrk andrewrk added this to the 0.4.0 milestone Jun 4, 2018
@mreiland
Copy link

mreiland commented Jun 4, 2018

I noticed that the last-modified header is incorrect and FF sent in the if-modified-since header with a date that matched the incorrect date-modified.

It looks like the server thinks the file hasn't been modified for some reason, most likely due to some interaction with amazon S3 (I think that's what you're using?). If so, investigating how to fix the last-modified may fix the issue.

@mreiland
Copy link

mreiland commented Jun 4, 2018

I did some more investigation, here's the documentation from Amazon, if you do a search for 'last-modified' you'll see the relevant section.

https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html

This isn't technically for the http headers I think, but I would be surprised if they're not used directly for said headers. Here's the relevant description of last-modified.

Object creation date or the last modified date, whichever is the latest.

I'm wondering if perhaps this is a caching issue on the server side? I'm not really familiar with S3 so I'm guessing here, but I wonder if their systems are just caching the information and being slow to update? Or if perhaps you're using something like cloudflare and it's caching? If so, purging that cache when you push an update may fix the issue.

Something to consider.

@andrewrk
Copy link
Member Author

andrewrk commented Nov 2, 2018

Here's my plan to fix this:

  • move travis & appveyor into azure pipelines
    • this also gives us more time, so we can re-enable release mode testing
  • have a job that gets triggered after any other (linux, macos, windows) build completes successfully. this job will update the URLs, file sizes, shasums, etc, on the download page directly. The redirect URL will be gone.

@andrewrk
Copy link
Member Author

andrewrk commented Apr 5, 2019

This exists now: https://ziglang.org/download/index.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants