Improve parameter replacement in set_fn function #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ziatdinovmax
commented
Oct 9, 2023
ziatdinovmax
commented
- Use regular expressions with word boundaries to replace parameter names in the source function.
- Ensure robust replacement even in cases where parameter names are surrounded by characters other than spaces, like parentheses.
- This resolves issues with functions that have parameters within expressions or parentheses.
- Use regular expressions with word boundaries to replace parameter names in the source function. - Ensure robust replacement even in cases where parameter names are surrounded by characters other than spaces, like parentheses. - This resolves issues with functions that have parameters within expressions or parentheses.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 95.89% 95.89%
=======================================
Files 41 41
Lines 3407 3408 +1
=======================================
+ Hits 3267 3268 +1
Misses 140 140
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.