Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

Parity with tdesktop #1401

Closed
wants to merge 1 commit into from
Closed

Parity with tdesktop #1401

wants to merge 1 commit into from

Conversation

goodmind
Copy link

@goodmind goodmind commented May 1, 2017

@bartist
Copy link
Contributor

bartist commented May 1, 2017

Can you indicate how this will change functionality?
Changing a filename will/should have impact somewhere on how the code works, so can you state where it will have impact?

@goodmind
Copy link
Author

goodmind commented May 1, 2017

@bartist this file never referenced in code, so functionality not affected

@bartist
Copy link
Contributor

bartist commented May 1, 2017

Ow, can you indicate why this change is necessary? or is it pure uniformity?

@goodmind
Copy link
Author

goodmind commented May 1, 2017

@bartist yes, just uniformity with tdesktop

@bartist
Copy link
Contributor

bartist commented May 1, 2017

Okay, thanks for the clarification :)

@stek29
Copy link
Collaborator

stek29 commented May 1, 2017

Isn't that file outdated and redurant? It's not used in Webogram, schema is in JSON inside of config.js anyways.

@zhukov
Copy link
Owner

zhukov commented Jun 28, 2017

@stek29 no, it isn't.

@zhukov
Copy link
Owner

zhukov commented Jun 28, 2017

See no point here, file contents is different, Webogram's one doesn't include mtproto, has the same formatting as on https://core.telegram.org/schema

@zhukov zhukov closed this Jun 28, 2017
@stek29
Copy link
Collaborator

stek29 commented Jun 28, 2017

@zhukov but what is it used for? JSON schema generation?

@zhukov
Copy link
Owner

zhukov commented Jun 28, 2017

@stek29 nope, it's for development. it's like very short documentation.

@stek29
Copy link
Collaborator

stek29 commented Jul 3, 2017

@goodmind
Copy link
Author

goodmind commented Jul 3, 2017

@zhukov why you want to keep txt extension?

@stek29
Copy link
Collaborator

stek29 commented Jul 4, 2017

@goodmind it's not just about txt extension.
I've spent last weekend digging through schema's in both webogram and tdesktop, and they differ a bit because of how these apps work with them -- TDesktop has mtp layer too, for example.

Also, why do you want this change in first place? What's the point? Does it worth breaking the links?

@goodmind
Copy link
Author

goodmind commented Jul 4, 2017

@stek29 because I merged Type Language highlight to github-linguist/linguist#3593

@stek29
Copy link
Collaborator

stek29 commented Jul 4, 2017

@goodmind Oh, it makes sense now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants