[MD] Update copy on index patten config DS step (opensearch-project#2527

) Issue Resolved: opensearch-project/ux#40 Signed-off-by: Kristen Tian <[email protected]> (cherry picked from commit ac07159) Signed-off-by: Su <[email protected]>
zhongnansu · Oct 12, 2022 · 467b19e · 467b19e
1 parent e7f0c97
commit 467b19e
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 85 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,7 +13,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 * [MD] Support legacy client for data source ([#2204](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2204))
 * [Plugin Helpers] Facilitate version changes ([#2398](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2398))
 * [MD] Display error toast for create index pattern with data source ([#2506](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2506))
-
+* [Multi DataSource] UX enhacement on index pattern management stack ([#2505](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2505))
+* [Multi DataSource] UX enhancement on Data source management stack ([#2521](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2521))
+* [Multi DataSource] UX enhancement on Index Pattern management stack ([#2527](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2527))
 ### 🐛 Bug Fixes
 * [Vis Builder] Fixes auto bounds for timeseries bar chart visualization ([2401](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2401))
 * [Vis Builder] Fixes visualization shift when editing agg ([2401](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2401))
@@ -49,7 +51,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 * Add updated_at column to objects' tables ([#1218](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1218)) 
 * [Viz Builder] State validation before dispatching and loading ([#2351](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2351))
-* [Multi DataSource] UX enhacement on index pattern management stack ([#2505]https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2505))
+* [Multi DataSource] UX enhacement on index pattern management stack ([#2505](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2505))
 * [Multi DataSource] UX enhancement on Data source management stack ([#2521](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2521))
 
 ### 🐛 Bug Fixes

diff --git a/src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts b/src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts
@@ -370,7 +370,8 @@ export class IndexPattern implements IIndexPattern {
     return this.dataSourceRef
       ? [
           {
-            ...this.dataSourceRef,
+            id: this.dataSourceRef.id,
+            type: this.dataSourceRef.type,
             name: DATA_SOURCE_REFERNECE_NAME,
           },
         ]

diff --git a/...n_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap b/...n_wizard/components/step_data_source/components/header/__snapshots__/header.test.tsx.snap
diff --git a/...nts/create_index_pattern_wizard/components/step_data_source/components/header/header.scss b/...nts/create_index_pattern_wizard/components/step_data_source/components/header/header.scss
diff --git a/...create_index_pattern_wizard/components/step_data_source/components/header/header.test.tsx b/...create_index_pattern_wizard/components/step_data_source/components/header/header.test.tsx
@@ -5,7 +5,6 @@
 
 import React from 'react';
 import { Header } from '../header';
-import { shallow } from 'enzyme';
 import { shallowWithIntl } from 'test_utils/enzyme_helpers';
 
 jest.mock('../../../../../../../../../plugins/opensearch_dashboards_react/public', () => ({

diff --git a/...ents/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx b/...ents/create_index_pattern_wizard/components/step_data_source/components/header/header.tsx
@@ -4,7 +4,6 @@
  */
 
 import React, { Fragment, useState } from 'react';
-import './header.scss';
 
 import {
   EuiButton,
@@ -111,7 +110,7 @@ export const Header: React.FC<HeaderProps> = (props: HeaderProps) => {
         <EuiText>
           <FormattedMessage
             id="indexPatternManagement.createIndexPattern.stepDataSourceLabel"
-            defaultMessage="Please pick the data source -- within which to configure index patterns."
+            defaultMessage="Pick a data source within which to configure index patterns."
           />
         </EuiText>
         <EuiSpacer size="m" />
@@ -121,49 +120,37 @@ export const Header: React.FC<HeaderProps> = (props: HeaderProps) => {
           label={
             <FormattedMessage
               id="indexPatternManagement.createIndexPattern.stepDataSource.useDefaultLabel"
-              defaultMessage="Use default"
+              defaultMessage="Use default data source"
             />
           }
           checked={defaultChecked}
           onChange={(e) => onChangeDefaultChecked(e)}
           compressed
         />
-        <EuiText size="s" className="dataSourceRadioHelperText">
-          <FormattedMessage
-            id="indexPatternManagement.createIndexPattern.stepDataSource.useDefault.helperText"
-            defaultMessage="Uses the default data source configured by the OpenSearch Dashboards administrator."
-          />
-        </EuiText>
-        <EuiSpacer size="l" />
+        <EuiSpacer size="m" />
         <EuiRadio
           data-test-subj="createIndexPatternStepDataSourceUseDataSourceRadio"
           id={'useDataSource'}
           label={
             <FormattedMessage
               id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSourceLabel"
-              defaultMessage="Choose data source"
+              defaultMessage="Use external data source connection"
             />
           }
           checked={dataSourceChecked}
           onChange={(e) => onChangeDataSourceChecked(e)}
           compressed
         />
-        <EuiText size="s" className="dataSourceRadioHelperText">
-          <FormattedMessage
-            id="indexPatternManagement.createIndexPattern.stepDataSource.useDataSource.helperText"
-            defaultMessage="Connect to an existing external data source."
-          />
-        </EuiText>
         {dataSourceChecked && (
           <EuiFlexItem grow={false}>
             <EuiSpacer size="m" />
             <EuiSelectable
-              aria-label={
-                <FormattedMessage
-                  id="indexPatternManagement.createIndexPattern.stepDataSource.searchLabel"
-                  defaultMessage="Search data sources"
-                />
-              }
+              aria-label={i18n.translate(
+                'indexPatternManagement.createIndexPattern.stepDataSource.searchlabel',
+                {
+                  defaultMessage: 'Search data sources',
+                }
+              )}
               searchable
               searchProps={{
                 'data-test-subj': 'selectDataSources',